I read a comment that said Roy Harper "used to be smart."
Uh, he is smart in fact I think he's written being smarter than he was pre-Flashpoint. The guy can now repair ALIEN TECH without help. Much like Pre-F Roy he uses jokes as a defense mechanism and has the same issues with Ollie not being supportive enough. Roy doesn't have a daughter so much of his previous growth is gone because he's not responsible for a child. This has nothing to do with who he's friends with. How extreme he acted (the lengths he went to get Rent-A-Bat started) was him desperate to do some good after suffering many losses and trying to pretend everything was fine.